adamsaghy commented on code in PR #3515:
URL: https://github.com/apache/fineract/pull/3515#discussion_r1365154052
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java:
##########
@@ -126,4 +134,20 @@ public CollectionData calculateLoanCollectionData(final
Long loanId) {
return collectionData;
}
+ @Override
+ public Collection<LoanInstallmentDelinquencyTagData>
retrieveLoanInstallmentsCurrentDelinquencyTag(Long loanId) {
Review Comment:
Please rewrite this to not load the loan (even if you fetch only a
reference, then moment you are fetching one of its field, its fetches the full
loan) and fetch one by one the installments and its delinquency tags, please do
it in one shot:
- Write a query that fetches them via the delinquency repository
You might wanna consider using:
https://www.baeldung.com/spring-data-jpa-projections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
