adamsaghy commented on code in PR #3515:
URL: https://github.com/apache/fineract/pull/3515#discussion_r1371855838


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -635,6 +636,9 @@ private Loan 
saveAndFlushLoanWithDataIntegrityViolationChecks(final Loan loan) {
          */
         try {
             
loanRepaymentScheduleInstallmentRepository.saveAll(loan.getRepaymentScheduleInstallments());
+            if (loan.isEnableInstallmentLevelDelinquency()) {

Review Comment:
   Please undo this. There must be a different place and way to handle it!



##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/starter/LoanAccountConfiguration.java:
##########
@@ -239,7 +241,8 @@ public LoanApplicationWritePlatformService 
loanApplicationWritePlatformService(P
                 configurationDomainService, loanScheduleAssembler, 
loanUtilService, calendarReadPlatformService,
                 entityDatatableChecksWritePlatformService, 
globalConfigurationRepository, entityMappingRepository,
                 fineractEntityRelationRepository, 
loanProductReadPlatformService, rateAssembler, 
glimAccountInfoWritePlatformService,
-                glimRepository, loanRepository, gsimReadPlatformService, 
defaultLoanLifecycleStateMachine);
+                glimRepository, loanRepository, gsimReadPlatformService, 
defaultLoanLifecycleStateMachine,
+                loanInstallmentDelinquencyTagRemovalService);

Review Comment:
   Please undo this. There must be a different place and way to handle it!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to