adamsaghy commented on code in PR #3545:
URL: https://github.com/apache/fineract/pull/3545#discussion_r1374540470
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/api/ChargesApiResourceSwagger.java:
##########
@@ -52,7 +52,7 @@ static final class GetChargesTimeTypeResponse {
private GetChargesTimeTypeResponse() {}
@Schema(example = "1")
- public Long id;
+ public Integer id;
Review Comment:
If you want to use Integer, you need to change the EnumOptionData class and
the ChargeEnumerations class chargeTimeType method which is converting the
getvalue from int to Long and creates the EnumOptionData.
Either you are changing everywhere or you are changing back from Integer to
Long in the swagger
Ultimately we cannot have different value in the swagger and in the DTO
which fills with values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
