vidakovic commented on code in PR #3563:
URL: https://github.com/apache/fineract/pull/3563#discussion_r1442549888
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/JdbcJavaType.java:
##########
@@ -136,11 +136,19 @@ public static JdbcJavaType getByTypeName(@NotNull
DatabaseType dialect, String n
for (JdbcJavaType type : values()) {
DialectType dialectType = type.getDialectType(dialect);
if (dialectType.getNameResolved().equals(name)) {
+ // NOTE: make MySQL systems happy aka TINYINT vs BOOLEAN issue!
Review Comment:
I use the code that you created. That's why I asked you for help a couple of
weeks ago, because you know your implementation (and the goals you want to
achieve with it) best. If you have an alternative that fixes the problem and
fits better in your database mapping mechanics then please send me a snippet.
Happy to replace.
But for now this is the least intrusive way that I could come up with in
5min. My goal is to create a working release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
