adamsaghy commented on code in PR #3957:
URL: https://github.com/apache/fineract/pull/3957#discussion_r1663741961
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/ChargeOrTransaction.java:
##########
@@ -58,7 +58,7 @@ private LocalDate getEffectiveDate() {
}
private boolean isBackdatedCharge() {
- return
loanCharge.get().getDueDate().isBefore(loanCharge.get().getSubmittedOnDate());
+ return (loanCharge.get().getDueDate() != null &&
loanCharge.get().getDueDate().isBefore(loanCharge.get().getSubmittedOnDate()));
Review Comment:
Unnecessary change. Would you mind to revert? If it is a fix for a bug
ticket, please extract it into a new PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
