alberto-art3ch commented on code in PR #3952:
URL: https://github.com/apache/fineract/pull/3952#discussion_r1665939890
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/ChargeOrTransaction.java:
##########
@@ -58,7 +58,7 @@ private LocalDate getEffectiveDate() {
}
private boolean isBackdatedCharge() {
- return
loanCharge.get().getDueDate().isBefore(loanCharge.get().getSubmittedOnDate());
+ return (loanCharge.get().getDueDate() != null &&
loanCharge.get().getDueDate().isBefore(loanCharge.get().getSubmittedOnDate()));
Review Comment:
Done! removed, It belongs to an issue when you have a Loan Installment Fee
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanSummaryData.java:
##########
@@ -91,9 +91,14 @@ public class LoanSummaryData {
private BigDecimal totalCreditBalanceRefundReversed;
private BigDecimal totalRepaymentTransaction;
private BigDecimal totalRepaymentTransactionReversed;
+ private BigDecimal totalInterestRefund;
+ private BigDecimal totalInterestPaymentWaiver;
private final Long chargeOffReasonId;
private final String chargeOffReason;
+ private BigDecimal totalUnpaidAccruedDueInterest;
Review Comment:
Done! Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
