kjozsa commented on code in PR #4035:
URL: https://github.com/apache/fineract/pull/4035#discussion_r1732901063
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/serialization/LoanProductDataValidator.java:
##########
@@ -569,7 +569,7 @@ public void validateForCreate(final JsonCommand command) {
Locale.getDefault());
baseDataValidator.reset().parameter(INTEREST_RATE_FREQUENCY_TYPE).value(interestRateFrequencyType).notNull().inMinMaxRange(0,
4);
- isInterestBearing =
interestRatePerPeriod.compareTo(BigDecimal.ZERO) > 0;
+ isInterestBearing =
BigDecimal.ZERO.compareTo(interestRatePerPeriod) < 0;
Review Comment:
I think this will throw the exact same NullpointerException as the previous
version. Same comment stands for the same changes below..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
