adamsaghy commented on code in PR #4046:
URL: https://github.com/apache/fineract/pull/4046#discussion_r1744128834
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationValidator.java:
##########
@@ -2123,6 +2126,7 @@ public static void validateOrThrow(String resource,
Consumer<DataValidatorBuilde
baseDataValidator.accept(dataValidatorBuilder);
if (!dataValidationErrors.isEmpty()) {
+ logger.info(dataValidationErrors.toString());
Review Comment:
Please remove this! Exception handler can decide whether they are logging
something or not. Also dont use "INFO" level logging for logging out exceptions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
