galovics commented on code in PR #4048:
URL: https://github.com/apache/fineract/pull/4048#discussion_r1747090180
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/ProgressiveLoanScheduleGenerator.java:
##########
@@ -103,11 +104,15 @@ public LoanScheduleModel generate(final MathContext mc,
final LoanApplicationTer
prepareDisbursementsOnLoanApplicationTerms(loanApplicationTerms);
+ final ArrayList<DisbursementData> disbursementDataList = new
ArrayList<>(loanApplicationTerms.getDisbursementDatas());
+
disbursementDataList.sort(Comparator.comparing(DisbursementData::disbursementDate));
Review Comment:
I mean what if there are two disbursements on the same date? Which one comes
first, do we know?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
