adamsaghy commented on code in PR #4139:
URL: https://github.com/apache/fineract/pull/4139#discussion_r1824532058
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -1560,6 +1560,12 @@ private Money
handlingPaymentAllocationForInterestBearingProgressiveLoan(LoanTra
paidPortion = processPaymentAllocation(paymentAllocationType,
installment, loanTransaction, transactionAmountUnprocessed,
loanTransactionToRepaymentScheduleMapping, charges, balances,
LoanRepaymentScheduleInstallment.PaymentAction.PAY);
+ if (installment.isDownPayment() ||
installment.getDueDate().isAfter(ctx.getModel().getMaturityDate())) {
Review Comment:
Also, please add some testing as well:
- Downpayment is configured on the loan
- We can pay the down payment and the regular installments
- Calculated balances are correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]