adamsaghy commented on code in PR #4166:
URL: https://github.com/apache/fineract/pull/4166#discussion_r1842480605
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/SingleLoanChargeRepaymentScheduleProcessingWrapper.java:
##########
@@ -46,7 +47,8 @@ public void reprocess(final MonetaryCurrency currency, final
LocalDate disbursem
totalPrincipal =
totalPrincipal.plus(installment.getPrincipal(currency));
}
LoanChargePaidBy accrualBy = null;
- if (!loan.isInterestBearing() && loanCharge.isSpecifiedDueDate()) { //
TODO: why only if not interest bearing
+ if ((!loan.isInterestBearing() ||
loan.getLoanProductRelatedDetail().getLoanScheduleType().equals(LoanScheduleType.PROGRESSIVE))
Review Comment:
Would you mind to remove the `!loan.isInterestBearing()` as well?
We should only have this:
`if (loanCharge.isSpecifiedDueDate())`,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
