adamsaghy commented on code in PR #4171:
URL: https://github.com/apache/fineract/pull/4171#discussion_r1856216625
##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/common/BatchApiStepDef.java:
##########
@@ -506,16 +505,13 @@ public void
runBatchApiCreateAndApproveLoanRescheduleWithGivenUser(String fromDa
});
}
- @When("Batch API call with created user and the following data results a
{int} error and a {string} error message:")
- public void
runBatchApiCreateAndApproveLoanRescheduleWithGivenUserLockedByCobError(int
errorCodeExpected, String errorMessageType,
+ @When("Batch API call with created user and the following data results a
{int} statuscode and a {string} error message:")
+ public void
runBatchApiCreateAndApproveLoanRescheduleWithGivenUserLockedByCobError(int
httpCodeExpected, String errorMessageType,
DataTable table) throws IOException {
String idempotencyKey = UUID.randomUUID().toString();
Response<PostLoansResponse> loanResponse =
testContext().get(TestContextKey.LOAN_CREATE_RESPONSE);
Long loanId = loanResponse.body().getLoanId();
- LoanRescheduleErrorMessage loanRescheduleErrorMessage =
LoanRescheduleErrorMessage.valueOf(errorMessageType);
Review Comment:
Why to remove these checks?
##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/common/BatchApiStepDef.java:
##########
@@ -542,17 +538,10 @@ public void
runBatchApiCreateAndApproveLoanRescheduleWithGivenUserLockedByCobErr
Boolean isEnclosingTransaction = Boolean.valueOf(enclosingTransaction);
Response<List<BatchResponse>> batchResponseList =
batchApiApi.handleBatchRequests(requestList, isEnclosingTransaction, headerMap)
.execute();
- String errorToString = batchResponseList.errorBody().string();
Review Comment:
Why to remove these checks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
