janez89 commented on PR #4215: URL: https://github.com/apache/fineract/pull/4215#issuecomment-2535339487
It looks good to me and just one note. If we touch these low-level SQL read services may would be nice to turn that concatenated strings into Java 15 multiline strings. If that string contains a full SQL command then the IDE is just able to highlight and autocomplete based on existing schema. https://github.com/apache/fineract/pull/4215/files#diff-2829a1a1111b3ced1fafd92d86574a957a2fa73d42fe5112f135301b71fda1c5R62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
