adamsaghy commented on code in PR #4234:
URL: https://github.com/apache/fineract/pull/4234#discussion_r1905691443
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanScheduleService.java:
##########
@@ -84,7 +84,7 @@ public ChangedTransactionDetail
recalculateScheduleFromLastTransaction(final Loa
public void regenerateRepaymentScheduleWithInterestRecalculation(final
Loan loan, final ScheduleGeneratorDTO generatorDTO) {
final LocalDate lastTransactionDate =
loan.getLastUserTransactionDate();
final LoanScheduleDTO loanSchedule =
loan.getRecalculatedSchedule(generatorDTO);
- if (loanSchedule == null) {
+ if (loanSchedule == null || loan.isChargedOff()) {
Review Comment:
Not needed... it is redundant... loan.getRecalculatedSchedule(generatorDTO)
will return null if loan is charged off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
