7ossam7atem1 opened a new pull request, #4357: URL: https://github.com/apache/fineract/pull/4357
## Description Fix Sonar-reported code quality issues in EntityTables enum: - Renamed VALUES field to ENTITY_VALUES to prevent clash with values() method - Changed static field access modifier to protected - Replaced Guava ImmutableList with Java List.of() These changes improve code quality by: 1. Preventing naming conflicts between fields and methods 2. Reducing potential misuse of static fields 3. Using native Java features instead of external dependencies Added comprehensive test suite (EntityTablesTest.java) with nested test classes to verify changes and ensure functionality. Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284). ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests Commit message: "FINERACT-2081: fix sonar issues in EntityTables enum" - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update unit or integration tests for verifying the changes made. Added EntityTablesTest.java with comprehensive test coverage: - Field access and values verification (@Nested FieldAccessTests) - Immutability verification (testCheckStatusesIsImmutable) - Entity operations validation (@Nested EntityOperationsTests) - Null handling scenarios (@Nested NullHandlingTests) - Entity names testing (@Nested EntityNamesTests) - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions. - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes No API changes were made; documentation updates not required. - [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.) FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
