VictorPavfurious commented on code in PR #4533:
URL: https://github.com/apache/fineract/pull/4533#discussion_r2026786931
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/account/data/PortfolioAccountData.java:
##########
@@ -69,6 +70,7 @@ public PortfolioAccountData(final Long id, final String
accountNo, final String
this.amtForTransfer = null;
}
+ @JsonIgnore
public String getCurrencyCode() {
Review Comment:
Yes, i agree with you. Or, we can rename this method in order to jackson
not serialize this field like "currencyCode" and use inside like
Optional.ofNullable(getCurrency()).map(currency ->
currency.getCode()).orElse(null), this allow for us avoid addition checks on
currency != null and NPE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
