adamsaghy commented on code in PR #4482: URL: https://github.com/apache/fineract/pull/4482#discussion_r2028719536
########## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java: ########## @@ -33,15 +33,18 @@ import java.util.Set; import lombok.Getter; import lombok.Setter; +import org.apache.commons.lang3.StringUtils; import org.apache.fineract.infrastructure.core.domain.AbstractAuditableWithUTCDateTimeCustom; import org.apache.fineract.infrastructure.core.service.DateUtils; import org.apache.fineract.infrastructure.core.service.MathUtil; import org.apache.fineract.organisation.monetary.domain.MonetaryCurrency; import org.apache.fineract.organisation.monetary.domain.Money; +import org.apache.fineract.portfolio.loanaccount.loanschedule.domain.LoanScheduleModelPeriod; import org.apache.fineract.portfolio.loanproduct.domain.AllocationType; import org.apache.fineract.portfolio.repaymentwithpostdatedchecks.domain.PostDatedChecks; @Getter +@Setter @Entity @Table(name = "m_loan_repayment_schedule") public class LoanRepaymentScheduleInstallment extends AbstractAuditableWithUTCDateTimeCustom<Long> Review Comment: Well, it could be versioned since it got updated, but i reckon the original idea was to version the main entity only (Loan) and there will not be situation where loan repayment schedule changes but loan does not... nevertheless, it might make sense to introduce versioning since it is updatable entity... but it is out of scope of this issue... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
