oleksii-novikov-onix commented on code in PR #4518:
URL: https://github.com/apache/fineract/pull/4518#discussion_r2028334402
##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/LoanStepDef.java:
##########
@@ -2390,6 +2413,13 @@ public void
checkLoanAccrualTransactionNotCreatedBusinessEvent(String date) thro
assertThat(transactions).as("Unexpected Accrual activity transaction
found on %s", date)
.noneMatch(t -> date.equals(FORMATTER.format(t.getDate())) &&
"Accrual Activity".equals(t.getType().getValue()));
+ if (transactions != null) {
+ for (GetLoansLoanIdTransactions t : transactions) {
+
eventAssertion.assertEventNotRaised(LoanAccrualTransactionCreatedBusinessEvent.class,
t.getId());
Review Comment:
We are checking all transactions (regardless of date) for the absence of
LoanAccrualTransactionCreatedBusinessEvent. Should we filter by date before
performing this check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
