adamsaghy commented on code in PR #4637:
URL: https://github.com/apache/fineract/pull/4637#discussion_r2083598115
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanChargeService.java:
##########
@@ -156,4 +160,48 @@ public void addLoanCharge(final Loan loan, final
LoanCharge loanCharge) {
loanLifecycleStateMachine.transition(LoanEvent.LOAN_CHARGE_ADDED,
loan);
}
+ public Money waiveLoanCharge(final LoanCharge loanCharge, final
MonetaryCurrency currency, final Integer loanInstallmentNumber) {
+ if (loanCharge.isInstalmentFee()) {
Review Comment:
I dont think it was good idea to move these internal state logic from
LoanCharge... I would say we can keep in the entities, simple, internal state
modification logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
