oleksii-novikov-onix commented on code in PR #4712:
URL: https://github.com/apache/fineract/pull/4712#discussion_r2120830368


##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForLoan.java:
##########
@@ -426,6 +430,33 @@ private void 
createJournalEntriesForChargeOffLoanCapitalizedIncomeAmortization(f
         }
     }
 
+    private void 
createJournalEntriesForCapitalizedIncomeAmortizationAdjustment(final LoanDTO 
loanDTO,
+            final LoanTransactionDTO loanTransactionDTO, final Office office) {
+        GLAccountBalanceHolder glAccountBalanceHolder = new 
GLAccountBalanceHolder();
+        if (MathUtil.isGreaterThanZero(loanTransactionDTO.getAmount())) {
+            populateCreditDebitMaps(loanDTO.getLoanProductId(), 
loanTransactionDTO.getAmount(), loanTransactionDTO.getPaymentTypeId(),
+                    
AccrualAccountsForLoan.DEFERRED_INCOME_LIABILITY.getValue(),
+                    
AccrualAccountsForLoan.INCOME_FROM_CAPITALIZATION.getValue(), 
glAccountBalanceHolder);

Review Comment:
   Here:
    - 4th parameter `DEFERRED_INCOME_LIABILITY` is specified as the credit 
account type
    - 5th parameter `INCOME_FROM_CAPITALIZATION` is specified as the debit 
account type
   
   But looking at the test cases in `LoanCapitalizedIncomeTest`:
   ```
   verifyJournalEntries(loanId, //
       …
       journalEntry(0.55, deferredIncomeLiabilityAccount, "DEBIT"), //
       journalEntry(0.55, feeIncomeAccount, "CREDIT") //
   );
   ```
   the correct accounting entries should be:
    - Debit for DEFERRED_INCOME_LIABILITY account
    - Credit for INCOME_FROM_CAPITALIZATION account
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to