adamsaghy commented on code in PR #4783:
URL: https://github.com/apache/fineract/pull/4783#discussion_r2155239901
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java:
##########
@@ -1948,6 +1915,287 @@ public DisbursementData
retrieveLoanDisbursementDetail(Long loanId, Long disburs
return this.jdbcTemplate.queryForObject(sql, rm, loanId,
disbursementId); // NOSONAR
}
+ @Override
Review Comment:
Seems unrelated, please raise separate PR with this functionality!
Also dont write native queries! Use JPQL + projections!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
