adamsaghy commented on code in PR #4770:
URL: https://github.com/apache/fineract/pull/4770#discussion_r2157086227
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanDownPaymentHandlerServiceImpl.java:
##########
@@ -95,7 +95,7 @@ public void
handleRepaymentOrRecoveryOrWaiverTransaction(final Loan loan, final
loanTransaction);
if (loanTransaction.isNotZero()) {
- loan.addLoanTransaction(loanTransaction);
+ loanTransactionRepository.save(loanTransaction);
Review Comment:
This looks not correct. If you dont add it to the loan transaction list,
than any logic which iterate through on that list will miss the transaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
