MarianaDmytrivBinariks commented on code in PR #4776:
URL: https://github.com/apache/fineract/pull/4776#discussion_r2163247135
##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/LoanStepDef.java:
##########
@@ -154,6 +154,7 @@
import org.apache.fineract.test.messaging.store.EventStore;
import org.apache.fineract.test.stepdef.AbstractStepDef;
import org.apache.fineract.test.support.TestContextKey;
+import org.assertj.core.api.SoftAssertions;
Review Comment:
I used it for checking a few fields values and wanted to get result of
checking all 3 of them(not fail at first incorrect value, but in case one, two
or all three fields have incorrect values), so I thought it's a good approach
to achieve this result, I've used SoftAssertions as found usages in a project,
shall I use diff approach/tool/dependency? or you mean just compare field by
field and fail at first incorrect value is better according our project
structure?
please advice
thanks in advance
here is usage:
SoftAssertions assertions = new SoftAssertions();
assertions.assertThat(buyDownFeeCalculationType).isEqualTo(targetProduct.getBuyDownFeeCalculationType().getValue());
assertions.assertThat(buyDownFeeStrategy).isEqualTo(targetProduct.getBuyDownFeeStrategy().getValue());
assertions.assertThat(buyDownFeeIncomeType).isEqualTo(targetProduct.getBuyDownFeeIncomeType().getValue());
assertions.assertAll();
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
