adamsaghy commented on code in PR #4837:
URL: https://github.com/apache/fineract/pull/4837#discussion_r2212780422
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionData.java:
##########
@@ -105,14 +105,17 @@ public final class SavingsAccountTransactionData
implements Serializable {
private BigDecimal overdraftAmount;
private transient Long modifiedId;
private transient String refNo;
+ private Boolean isNegativeBalance;
+ private Boolean flagValidationInterest;
+ private Boolean flagValidationOverdraft;
private SavingsAccountTransactionData(final Long id, final
SavingsAccountTransactionEnumData transactionType,
final PaymentDetailData paymentDetailData, final Long savingsId,
final String savingsAccountNo, final LocalDate transactionDate,
final CurrencyData currency, final BigDecimal amount, final
BigDecimal outstandingChargeAmount, final BigDecimal runningBalance,
final boolean reversed, final AccountTransferData transfer, final
Collection<PaymentTypeData> paymentTypeOptions,
final LocalDate submittedOnDate, final boolean
interestedPostedAsOn, final String submittedByUsername, final String note,
final Boolean isReversal, final Long originalTransactionId,
boolean isManualTransaction, final Boolean lienTransaction,
- final Long releaseTransactionId, final String reasonForBlock) {
+ final Long releaseTransactionId, final String reasonForBlock,
final Boolean isNegativeBalance) {
Review Comment:
What does negative balance mean here? I dont think transaction should have
negative amount! It is really uncommon in Fineract!
@bharathc27 FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
