adamsaghy commented on code in PR #4837:
URL: https://github.com/apache/fineract/pull/4837#discussion_r2213148596
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java:
##########
@@ -939,14 +944,28 @@ private boolean hasOverdraftInterestCalculation() {
return isAllowOverdraft() && !MathUtil.isEmpty(getOverdraftLimit()) &&
!MathUtil.isEmpty(nominalAnnualInterestRateOverdraft);
}
+ public List<SavingsAccountTransaction>
retreiveOrderedAccrualTransactions() {
Review Comment:
typo in the name.
No need to sort them again... since the list is already sorted...or not?
Also really dont need all this:
`return
retrieveListOfTransactions().stream().filter(SavingsAccountTransaction::isAccrual).toList()`
If your really want to sort then:
`retrieveListOfTransactions().stream().filter(SavingsAccountTransaction::isAccrual).sorted(new
SavingsAccountTransactionComparator()).toList();`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
