meonkeys opened a new pull request, #4915:
URL: https://github.com/apache/fineract/pull/4915

   ## Description
   
   See FINERACT-2336 and detailed change descriptions in the commit log message.
   
   Please have a look at the rendered 
[HTML](https://adammonsen.com/tmp/FINERACT-2336/index.html) and 
[PDF](https://adammonsen.com/tmp/FINERACT-2336/index.pdf) outputs, and compare 
them with <https://fineract.apache.org/docs/current/>.
   
   Please pay special attention to changes in "Step 13: Close Release 
Branch"--there's an [open 
discussion](https://mifos.slack.com/archives/C028634A61L/p1754005222134299?thread_ts=1753726336.645799&cid=C028634A61L)
 about how to do this properly. The steps work as indicated in this patch, but 
it eschews a flat commit trail in favor of simplicity while closing a release 
branch.
   
   Also note I originally created https://github.com/apache/fineract/pull/4914 
but since the branch was in the `apache/fineract` repo it was causing many 
duplicate GH actions CI job runs.
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [x] Write the commit message as per 
https://github.com/apache/fineract/#pull-requests
   - [x] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [x] Create/update unit or integration tests for verifying the changes made.
   - [x] Follow coding conventions at 
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   - [x] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   - [x] Submission is not a "code dump".  (Large changes can be made "in 
repository" via a branch.  Ask on the developer mailing list for guidance, if 
required.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to