adamsaghy commented on code in PR #4623:
URL: https://github.com/apache/fineract/pull/4623#discussion_r2259502610
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/RecurringDepositAccount.java:
##########
@@ -91,6 +93,24 @@ public class RecurringDepositAccount extends SavingsAccount {
@OneToMany(cascade = CascadeType.ALL, mappedBy = "account", orphanRemoval
= true, fetch = FetchType.LAZY)
private List<RecurringDepositScheduleInstallment>
depositScheduleInstallments = new ArrayList<>();
+ @Transient
+ private ConfigurationDomainService configurationDomainService;
+
+ /**
+ * Returns an appropriate ExternalId based on configuration settings. If
auto-generation is enabled and provided
+ * externalId is empty, generate a new one.
+ */
+ public ExternalId getExternalId(ExternalId externalId) {
Review Comment:
No need for this, use `ExternalIdFactory`
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/FixedDepositAccount.java:
##########
@@ -83,6 +83,21 @@ public class FixedDepositAccount extends SavingsAccount {
@Transient
private ConfigurationDomainService configurationDomainService;
+ public void setConfigurationDomainService(ConfigurationDomainService
configurationDomainService) {
+ this.configurationDomainService = configurationDomainService;
+ }
+
+ /**
+ * Returns an appropriate ExternalId based on configuration settings. If
auto-generation is enabled and the provided
+ * externalId is empty, generate a new one.
+ */
+ public ExternalId getExternalId(ExternalId externalId) {
Review Comment:
No need for this, use `ExternalIdFactory`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
