Re: [PR] FINERACT-2326: Tax component and group issue serialization [fineract]

[via GitHub]

adamsaghy commented on PR #4928:
URL: https://github.com/apache/fineract/pull/4928#issuecomment-3166930881

   > > I dont understand this PR. You removed the Serializable interface and 
using lombok... what serialization issue you are referring to?
   > 
   > @adamsaghy There is an issue with the TaxComponent and TaxGroup DTO please 
see the attached image, the `taxGroupOption` field has empty objects
   > 
   > <img alt="Screenshot 2025-08-07 at 7 56 55 p m" width="1545" height="1110" 
src="https://private-user-images.githubusercontent.com/154766431/475852763-907f341c-9206-4690-b50d-f5812eccec44.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTQ2NDAzNTMsIm5iZiI6MTc1NDY0MDA1MywicGF0aCI6Ii8xNTQ3NjY0MzEvNDc1ODUyNzYzLTkwN2YzNDFjLTkyMDYtNDY5MC1iNTBkLWY1ODEyZWNjZWM0NC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwODA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDgwOFQwODAwNTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05NTczM2I4ZmMyYmI0YTViMzNlYzlhNmY3OTg4MDQzZWMwZjYzZmRlYWZjYjE4MDYyODU5OTAxZDZhNjI1OGU0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Bkl-ZVW3ODc1UlKa5ae4sHdvldXYwyVil717bf2dp4Q";>
   
   I think the issue was with the missing getter, setter, constructor... not 
the Serializable interface itself... would you mind to put it back?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org