adamsaghy commented on code in PR #4885:
URL: https://github.com/apache/fineract/pull/4885#discussion_r2272726083
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountTransaction.java:
##########
@@ -198,6 +199,15 @@ public static SavingsAccountTransaction withdrawal(final
SavingsAccount savingsA
date, amount, isReversed, isManualTransaction,
lienTransaction, refNo);
}
+ public static SavingsAccountTransaction accrual(final SavingsAccount
savingsAccount, final Office office, final LocalDate date,
+ final Money amount, final boolean isManualTransaction) {
+ final boolean isReversed = false;
+ final Boolean lienTransaction = false;
+ final String refNo = ExternalId.generate().getValue();
Review Comment:
refNo is not external id, please leave it empty, or let it be provided from
outside!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
