sidhantgoel commented on code in PR #4939:
URL: https://github.com/apache/fineract/pull/4939#discussion_r2275433386
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/tax/service/TaxReadPlatformServiceImpl.java:
##########
@@ -52,7 +52,9 @@ public class TaxReadPlatformServiceImpl implements
TaxReadPlatformService {
@Override
public List<TaxComponentData> retrieveAllTaxComponents() {
String sql = "select " + TAX_COMPONENT_MAPPER.getSchema();
- return this.jdbcTemplate.query(sql, TAX_COMPONENT_MAPPER); // NOSONAR
+ return this.jdbcTemplate.query(con -> con.prepareStatement(sql,
+
ResultSet.TYPE_SCROLL_SENSITIVE,
Review Comment:
If we dont use this, the resulset returned in case of PostgreSQL we can
navigate in only one direction. but since we are moving back in some cases a
scrollable result set is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
