adamsaghy commented on code in PR #4932:
URL: https://github.com/apache/fineract/pull/4932#discussion_r2282412088
##########
fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersWriteServiceImpl.java:
##########
@@ -410,6 +413,7 @@ private ExternalAssetOwnerTransfer createSaleTransfer(Long
loanId, JsonElement j
externalAssetOwnerTransfer.setLoanId(loanId);
externalAssetOwnerTransfer.setExternalLoanId(externalLoanId);
externalAssetOwnerTransfer.setExternalGroupId(getTransferExternalGroupIdFromJson(json));
+ externalAssetOwnerTransfer.setPreviousOwner(null);
Review Comment:
This is incorrect. We should check whether it is already owned by external
owner and use that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
