JohnAlva commented on code in PR #4886:
URL: https://github.com/apache/fineract/pull/4886#discussion_r2308398557
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountInterestPostingServiceImpl.java:
##########
@@ -500,7 +606,7 @@ protected SavingsAccountTransactionData
findInterestPostingTransactionFor(final
SavingsAccountTransactionData postingTransation = null;
List<SavingsAccountTransactionData> trans =
savingsAccountData.getSavingsAccountTransactionData();
for (final SavingsAccountTransactionData transaction : trans) {
- if ((transaction.isInterestPostingAndNotReversed() ||
transaction.isOverdraftInterestAndNotReversed())
+ if ((transaction.isInterestPostingAndNotReversed() &&
transaction.isOverdraftInterestAndNotReversed())
Review Comment:
I’ve updated the integration tests to assert the presence of exactly one
interest or overdraft posting on the posting date for each scenario. With the
current logic (||), all tests pass, but if we change it to &&, the single-type
scenarios fail as expected. This ensures the behavior is now properly covered
by tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
