meonkeys commented on code in PR #5039:
URL: https://github.com/apache/fineract/pull/5039#discussion_r2355957387
##########
fineract-doc/build.gradle:
##########
@@ -16,9 +16,49 @@
* specific language governing permissions and limitations
* under the License.
*/
+
+buildscript {
+ repositories {
+ mavenCentral()
+ gradlePluginPortal()
+ }
+
+ dependencies {
+ classpath 'org.asciidoctor:asciidoctor-gradle-jvm:4.0.4'
+ classpath 'org.asciidoctor:asciidoctor-gradle-jvm-pdf:4.0.4'
Review Comment:
let's use 4.0.5
##########
fineract-doc/build.gradle:
##########
@@ -16,9 +16,49 @@
* specific language governing permissions and limitations
* under the License.
*/
+
+buildscript {
+ repositories {
+ mavenCentral()
+ gradlePluginPortal()
+ }
+
+ dependencies {
+ classpath 'org.asciidoctor:asciidoctor-gradle-jvm:4.0.4'
+ classpath 'org.asciidoctor:asciidoctor-gradle-jvm-pdf:4.0.4'
+ classpath 'org.yaml:snakeyaml:1.33'
+ }
+}
+
+plugins {
+ id 'org.asciidoctor.jvm.convert' version '4.0.4' apply false
+ id 'org.asciidoctor.jvm.pdf' version '4.0.4' apply false
Review Comment:
4.0.5
##########
build.gradle:
##########
@@ -108,8 +108,8 @@ plugins {
// https://github.com/asciidoctor/asciidoctorj-pdf/issues/25
// https://github.com/jruby/jruby/issues/5573
// https://github.com/asciidoctor/asciidoctorj-pdf/issues/16
- id 'org.asciidoctor.jvm.convert' version '3.3.2' apply false
- id 'org.asciidoctor.jvm.pdf' version '3.3.2' apply false
+ id 'org.asciidoctor.jvm.convert' version '4.0.4' apply false
Review Comment:
Please remove "can't upgrade" comments: Lines 107-110
##########
build.gradle:
##########
@@ -108,8 +108,8 @@ plugins {
// https://github.com/asciidoctor/asciidoctorj-pdf/issues/25
// https://github.com/jruby/jruby/issues/5573
// https://github.com/asciidoctor/asciidoctorj-pdf/issues/16
- id 'org.asciidoctor.jvm.convert' version '3.3.2' apply false
- id 'org.asciidoctor.jvm.pdf' version '3.3.2' apply false
+ id 'org.asciidoctor.jvm.convert' version '4.0.4' apply false
+ id 'org.asciidoctor.jvm.pdf' version '4.0.4' apply false
Review Comment:
4.0.5
##########
renovate.json:
##########
@@ -37,7 +37,7 @@
},
{
"matchPackageNames": ["org.asciidoctor.jvm.convert",
"org.asciidoctor.jvm.pdf"],
- "allowedVersions": "<=3.3.2"
+ "allowedVersions": "<=4.0.4"
},
Review Comment:
how about we just remove this? An auto-upgrade from 4.0.4 to 4.0.5 would
have worked, for example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
