adamsaghy commented on code in PR #5068:
URL: https://github.com/apache/fineract/pull/5068#discussion_r2395701010


##########
fineract-provider/src/main/resources/application.properties:
##########
@@ -71,6 +71,11 @@ 
fineract.correlation.header-name=${FINERACT_LOGGING_HTTP_CORRELATION_ID_HEADER_N
 fineract.job.stuck-retry-threshold=${FINERACT_JOB_STUCK_RETRY_THRESHOLD:5}
 fineract.ip-tracking.enabled=${FINERACT_CLIENT_IP_TRACKING_ENABLED:false}
 fineract.job.loan-cob-enabled=${FINERACT_JOB_LOAN_COB_ENABLED:true}
+# Aggregation job configuration
+fineract.job.aggregation-lookback-days=${FINERACT_JOB_AGGREGATION_LOOKBACK_DAYS:2}

Review Comment:
   you misunderstood this property: The configured days are deducted from the 
"aggregated on date" / current business date and allows to aggregate till 
"current business date - lookback days". But i feel your confusion, let me 
rename it :)



##########
fineract-provider/src/main/resources/application.properties:
##########
@@ -71,6 +71,11 @@ 
fineract.correlation.header-name=${FINERACT_LOGGING_HTTP_CORRELATION_ID_HEADER_N
 fineract.job.stuck-retry-threshold=${FINERACT_JOB_STUCK_RETRY_THRESHOLD:5}
 fineract.ip-tracking.enabled=${FINERACT_CLIENT_IP_TRACKING_ENABLED:false}
 fineract.job.loan-cob-enabled=${FINERACT_JOB_LOAN_COB_ENABLED:true}
+# Aggregation job configuration
+fineract.job.aggregation-lookback-days=${FINERACT_JOB_AGGREGATION_LOOKBACK_DAYS:2}

Review Comment:
   you misunderstood this property: The configured days are deducted from the 
"aggregated on date" / current business date and allows to aggregate till 
"current business date - lookback days". But i understand your confusion, let 
me rename it :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to