adamsaghy commented on code in PR #5053:
URL: https://github.com/apache/fineract/pull/5053#discussion_r2431917146
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -3021,7 +3361,7 @@ private void
updateRepaymentPeriodsAfterAccelerateMaturityDate(final Progressive
final RepaymentPeriod lastPeriod =
periodsBeforeAccelerateMaturity.getLast();
- final List<RepaymentPeriod> periodsToRemove =
repaymentPeriods.stream().filter(rp ->
rp.getFromDate().isAfter(transactionDate))
+ final List<RepaymentPeriod> periodsToRemove =
repaymentPeriods.stream().filter(rp ->
!rp.getFromDate().isBefore(transactionDate))
Review Comment:
Are you sure this correct? from date usually belongs to the previous period
as it is the due date
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
