budaidev commented on code in PR #5082: URL: https://github.com/apache/fineract/pull/5082#discussion_r2419881481
########## fineract-client-feign/src/main/java/org/apache/fineract/client/feign/services/ImagesApi.java: ########## @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.client.feign.services; + +import feign.Headers; +import feign.Param; +import feign.QueryMap; +import feign.RequestLine; +import feign.Response; +import java.io.File; +import java.util.Map; + +/** + * Client API (Feign) for /images. + * + * This class is entirely hand-written, inspired by DocumentsApiFixed, and from /images methods which currently end up + * in DefaultApi (see <a href="https://issues.apache.org/jira/browse/FINERACT-1222";>FINERACT-1222</a>), but fixed for + * bugs in the code generation (see <a href="https://issues.apache.org/jira/browse/FINERACT-1227";>FINERACT-1227</a>). + */ +public interface ImagesApi { Review Comment: Generated methods don't support Data URL format: - Server expects data:image/jpeg;base64, format - Generated API doesn't include prepareFileUpload() helper method - No proper Content-Type handling for data URLs ########## fineract-client-feign/src/main/java/org/apache/fineract/client/feign/services/RunReportsApi.java: ########## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.client.feign.services; + +import feign.Param; +import feign.QueryMap; +import feign.RequestLine; +import feign.Response; +import java.util.Map; +import org.apache.fineract.client.models.RunReportsResponse; + +public interface RunReportsApi { Review Comment: Generated API cannot handle multiple response formats: - Reports can return JSON, CSV, PDF, HTML, XLS, XLSX - Need two methods: - runReportGetData() - Returns parsed RunReportsResponse (JSON) - runReportGetFile() - Returns raw Response (binary formats) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
