adamsaghy commented on code in PR #5019:
URL: https://github.com/apache/fineract/pull/5019#discussion_r2387927602
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/ReprocessLoanTransactionsServiceImpl.java:
##########
@@ -208,8 +209,12 @@ private void handleChangedDetail(final
ChangedTransactionDetail changedTransacti
if (oldTransaction != null) {
loanAccountTransfersService.updateLoanTransaction(oldTransaction.getId(),
newTransaction);
- // Create reversal journal entries for old transaction if it
exists (reverse-replay scenario)
-
loanJournalEntryPoster.postJournalEntriesForLoanTransaction(oldTransaction,
false, false);
+ // Only create reversal journal entries for old transaction if
the old transaction is not already
Review Comment:
Are you sure? I dont recall any reported bug whether something was
incorrectly or double accounted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
