mariiaKraievska commented on code in PR #5121:
URL: https://github.com/apache/fineract/pull/5121#discussion_r2454181569


##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/initializer/global/LoanProductGlobalInitializerStep.java:
##########
@@ -3156,7 +3154,6 @@ public void initialize() throws Exception {
         final PostLoanProductsRequest 
loanProductsRequestLP2AdvPaymentInstallmentFeeFlatPlusInterestChargesMultiDisburse
 = loanProductsRequestLP2AdvPaymentInstallmentFeePercentInterestCharges//
                 .name(name121)//
                 .charges(chargesInstallmentFeeFlatPlusInterest)//
-                .shortName(Utils.randomNameGenerator(SHORT_NAME_PREFIX_EMI, 
3))//

Review Comment:
   I believe you forgot to replace it with 
`.shortName(loanProductsRequestFactory.generateShortNameSafely())`, that`s why 
pipeline failed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to