Aman-Mittal commented on code in PR #5251:
URL: https://github.com/apache/fineract/pull/5251#discussion_r2649033469
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -1767,18 +1767,12 @@ private void allocateOverpayment(LoanTransaction
loanTransaction, TransactionCtx
private boolean shouldUseEmiCalculation(TransactionCtx transactionCtx,
LocalDate transactionDate) {
if (transactionCtx instanceof ProgressiveTransactionCtx
progressiveTransactionCtx) {
- boolean hasActiveReAmortization =
progressiveTransactionCtx.getAlreadyProcessedTransactions().stream()
Review Comment:
Can you explain the removal of this logic? hasActiveReAmortization. Even
through tests wise code is ok.
Interested in usecase related point of view. why re amortize logic is being
removed here/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
