Aman-Mittal commented on code in PR #5245:
URL: https://github.com/apache/fineract/pull/5245#discussion_r2649266996
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanAccrualActivityProcessingServiceImpl.java:
##########
@@ -241,27 +249,42 @@ public void processAccrualActivityForLoanReopen(final
@NonNull Loan loan) {
}
}
- private void calculateAccrualActivity(LoanTransaction loanTransaction,
MonetaryCurrency currency,
- List<LoanRepaymentScheduleInstallment> installments) {
-
+ private boolean calculateAccrualActivity(LoanTransaction loanTransaction,
MonetaryCurrency currency,
Review Comment:
This function has cognitive complexity of 27, it should be broken down to
smaller functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
