adamsaghy commented on code in PR #5219:
URL: https://github.com/apache/fineract/pull/5219#discussion_r2661156344


##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -227,6 +227,12 @@ public Pair<ChangedTransactionDetail, 
ProgressiveLoanInterestScheduleModel> repr
         final Integer installmentAmountInMultiplesOf = 
loan.getLoanProductRelatedDetail().getInstallmentAmountInMultiplesOf();
         ProgressiveLoanInterestScheduleModel scheduleModel = 
emiCalculator.generateInstallmentInterestScheduleModel(installments,
                 LoanConfigurationDetailsMapper.map(loan), 
installmentAmountInMultiplesOf, overpaymentHolder.getMoneyObject().getMc());
+

Review Comment:
   This whole thing can be handled as part of 
`emiCalculator.generateInstallmentInterestScheduleModel`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to