Monica-CodingWorld commented on PR #5264: URL: https://github.com/apache/fineract/pull/5264#issuecomment-3729327448
> @Monica-CodingWorld, thanks for the "Testing" section in the original PR description. What does "Verified Liquibase changelog integrity locally" mean? > > I suggest adding to your acceptance/verification testing: > > 1. Perform all the usual developer code sanity/smoke checks Ádám Sághy mentioned / make sure build passes / etc. > 2. Per [FINERACT-2423](https://issues.apache.org/jira/browse/FINERACT-2423) description, run the server or a release jar and make sure the warning no longer appears. > 3. Test your changes with synthetic data. > > Caveats to my advice: (a) there might already be tests for migrations and (b) I don't know where to get synthetic data. @meonkeys Thanks for the feedback and the suggestions. By “Verified Liquibase changelog integrity locally” I meant that after correcting the invalid changelog filename, I ran the application locally and confirmed that Liquibase starts without checksum or changelog integrity warnings. The migrations are applied normally and Liquibase no longer reports the filename-related warning that motivated FINERACT-2423. For acceptance/verification testing I have done the following so far: - Performed the usual sanity/smoke checks: project builds successfully and tests run. - Started the Fineract server locally and confirmed that the previous Liquibase warning about the changelog filename no longer appears. - Verified that Liquibase executes the migrations without checksum/integrity errors. - Created sample data through the UI/API (clients and loans) to make sure the application behaves normally after the migration. This PR is intentionally limited to fixing the invalid Liquibase changelog filename; it does not introduce functional changes. I appreciate your notes about synthetic data and migration tests — I will also review the existing migration tests to see what already exists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
