airajena commented on PR #5441: URL: https://github.com/apache/fineract/pull/5441#issuecomment-3941476418
> I think grace periods / moratorium is something that we know from Day 1 and the repayment schedule should be calculated and reflect its side effects, no? EMI calculation should consider and calculate an EMI which remains the same across the periods anyway, no? Thanks, Adam — agreed with your direction. I reviewed the current implementation and studied some banking terms too and you’re right: it currently relies on period-index checks and post-processing, rather than modeling moratorium from schedule generation time. It also doesn’t properly reuse the existing interest-pause mechanism as intended. So I am thinking to these things Model moratorium/grace from Day 1 in the schedule calculation flow, use the existing interest-pause logic/mechanics for interest moratorium instead of custom period-number checks, remove the current ad-hoc grace checks and EMI-skip shortcut, keep EMI behavior consistent with the configured schedule and expected examples. I think i am moving in the right direction now. Also surely @bharathc27 opinion will be helpful I’ll update the tests accordingly and push a cleaned-up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
