adamsaghy commented on code in PR #5483:
URL: https://github.com/apache/fineract/pull/5483#discussion_r2847754134
##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloanproduct/domain/WorkingCapitalLoanProduct.java:
##########
@@ -18,6 +18,124 @@
*/
package org.apache.fineract.portfolio.workingcapitalloanproduct.domain;
-public class WorkingCapitalLoanProduct {
+import jakarta.persistence.CascadeType;
+import jakarta.persistence.Column;
+import jakarta.persistence.Embedded;
+import jakarta.persistence.Entity;
+import jakarta.persistence.FetchType;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.ManyToOne;
+import jakarta.persistence.OneToMany;
+import jakarta.persistence.OneToOne;
+import jakarta.persistence.Table;
+import jakarta.persistence.UniqueConstraint;
+import java.time.LocalDate;
+import java.util.ArrayList;
+import java.util.List;
+import lombok.AccessLevel;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.Setter;
+import
org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom;
+import org.apache.fineract.infrastructure.core.domain.ExternalId;
+import org.apache.fineract.portfolio.delinquency.domain.DelinquencyBucket;
+import org.apache.fineract.portfolio.fund.domain.Fund;
+
+/**
+ * Working Capital Loan Product entity. This is a separate entity from the
standard LoanProduct to provide flexibility
+ * for configuring Working Capital loan products without impacting existing
loan products.
+ */
+@Entity
+@Getter
+@Setter
+@NoArgsConstructor(access = AccessLevel.PROTECTED)
+@Table(name = "m_wcp_product", uniqueConstraints = {
@UniqueConstraint(columnNames = { "name" }, name = "unq_wcp_name"),
Review Comment:
`m_wc_loan_product`?
lets use the following prefixes:
For product: `m_wc_loan_product_`
For loan: `m_wc_loan_`
For both/neither: `m_wc_`
what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
