airajena commented on code in PR #5565:
URL: https://github.com/apache/fineract/pull/5565#discussion_r2881797749
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChart.java:
##########
@@ -177,9 +177,6 @@ public void validateChartSlabs(DataValidatorBuilder
baseDataValidator) {
}
}
- } else if (iSlabs.slabFields().isNotProperPriodEnd()) {
Review Comment:
To be clear, I removed that intentionally because that branch effectively
became unreachable after we tightened the slab-range validation. Previously,
isNotProperPriodEnd() acted as a bit of a fallback safety net. But with the way
the validation flow works now, we’re validating period bounds (consistency
between fromPeriod and toPeriod) much earlier. On top of that, the slab
ordering and continuity checks already catch and reject any invalid end-period
combinations. The issue was that keeping that extra check actually started
tripping up and rejecting valid edge cases—specifically when toPeriod is
open-ended or derived by the chart boundaries. So, the goal was really to get
rid of duplicate/conflicting validation rather than relaxing the rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
