DeathGun44 opened a new pull request, #5593: URL: https://github.com/apache/fineract/pull/5593
## Description `LoanApplicationTerms.updateAnnualNominalInterestRate()` did not invalidate the cached `fixedEmiAmount` when the interest rate changed. This caused exact repayments on cumulative loans with floating rates to only adjust the last installment, while overpayments correctly recalculated all future installments. **Fix:** Reset `fixedEmiAmount = null` when the annual nominal interest rate actually changes, forcing EMI recalculation for all subsequent installments. Added integration test ([FloatingRateInterestRecalculationTest](cci:2://file:///home/deathgun/fineract/integration-tests/src/test/java/org/apache/fineract/integrationtests/FloatingRateInterestRecalculationTest.java:61:0-226:1)) to verify the fix with both exact repayment and overpayment scenarios. ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
