adamsaghy commented on code in PR #5349:
URL: https://github.com/apache/fineract/pull/5349#discussion_r2904060369
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -1168,6 +1170,7 @@ public Map<String, Object> makeLoanBulkRepayment(final
CollectionSheetBulkRepaym
for (final SingleRepaymentCommand singleLoanRepaymentCommand :
repaymentCommand) {
if (singleLoanRepaymentCommand != null) {
final Loan loan =
this.loanAssembler.assembleFrom(singleLoanRepaymentCommand.getLoanId());
+
loanTransactionValidator.validateLoanNotClosedOrOverpaidForTransactions(loan,
LoanTransactionType.REPAYMENT);
Review Comment:
see above.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -1390,6 +1393,7 @@ public CommandProcessingResult waiveInterestOnLoan(final
Long loanId, final Json
Loan loan = this.loanAssembler.assembleFrom(loanId);
checkClientOrGroupActive(loan);
+
loanTransactionValidator.validateLoanNotClosedOrOverpaidForTransactions(loan,
LoanTransactionType.WAIVE_INTEREST);
Review Comment:
see above.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -2869,6 +2873,7 @@ public CommandProcessingResult makeRefund(final Long
loanId, final LoanTransacti
changes.put(LoanApiConstants.externalIdParameterName, txnExternalId);
Loan loan = this.loanAssembler.assembleFrom(loanId);
+
loanTransactionValidator.validateLoanNotClosedOrOverpaidForTransactions(loan,
loanTransactionType);
Review Comment:
see above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
