adamsaghy commented on code in PR #5594:
URL: https://github.com/apache/fineract/pull/5594#discussion_r2904254823
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/provisioning/service/ProvisioningEntriesReadPlatformServiceImpl.java:
##########
@@ -114,11 +114,11 @@ public ProvisioningEntryData
retrieveProvisioningEntryData(Long entryId) {
private static final class ProvisioningEntryDataMapper implements
RowMapper<ProvisioningEntryData> {
- private final StringBuilder sqlQuery = new StringBuilder()
- .append(" entry.id, entry.journal_entry_created,
entry.createdby_id, entry.created_date, created.username as createduser,")
- .append("entry.lastmodifiedby_id, modified.username as
modifieduser, entry.lastmodified_date ")
- .append("from m_provisioning_history entry ").append("left
JOIN m_appuser created ON created.id = entry.createdby_id ")
- .append("left JOIN m_appuser modified ON modified.id =
entry.lastmodifiedby_id ");
+ private static final String PROVISIONING_ENTRY_SCHEMA = """
+ entry.id, entry.journal_entry_created, entry.createdby_id,
entry.created_date, created.username as createduser,
+ entry.lastmodifiedby_id, modified.username as modifieduser,
entry.lastmodified_date
+ from m_provisioning_history entry left JOIN m_appuser created
ON created.id = entry.createdby_id
+ left JOIN m_appuser modified ON modified.id =
entry.lastmodifiedby_id\s""";
Review Comment:
Do we need that `\s`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
