AshharAhmadKhan commented on PR #5498:
URL: https://github.com/apache/fineract/pull/5498#issuecomment-4033499301
@adamsaghy done — changed `DisbursementDetail.principal` from `Double` to
`BigDecimal` in `LoanDisbursementDetailApiResourceSwagger.java` and updated all
call sites:
- `ProgressiveLoanTrancheTest.java` line 70: removed `.doubleValue()`, now
passes `getPrincipal()` directly
- `ProgressiveLoanTrancheTest.java` line 73: changed `100.0` to
`BigDecimal.valueOf(100.0)`
- `LoanStepDef.java` line 1669: removed `.doubleValue()` on the existing
disbursement loop
- `LoanStepDef.java` line 1675: wrapped `disbursementAmount` with
`BigDecimal.valueOf()` since the Cucumber `{double}` binding requires the
method parameter to stay `Double`
Spotless, SpotBugs, and full compile all pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
