This is an automated email from the ASF dual-hosted git repository.
meonkeys pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new 31a1036686 add required_pull_request_reviews param
31a1036686 is described below
commit 31a1036686b8b5d1113b457cd546a648aa970497
Author: Adam Monsen <[email protected]>
AuthorDate: Wed May 13 11:32:46 2026 -0700
add required_pull_request_reviews param
should fix this:
An error occurred while processing the github feature in .asf.yaml:
Validation failed while creating ruleset 'Branch Protection': Invalid
request.
Invalid property /rules/3: data matches no possible input. See
`documentation_url`.
It appears a required_pull_request_reviews mapping is required for the
.asf.yaml parser to send all the params required for pull_request
(that's the field name in the actual GitHub rulesets creation api
endpoint).
See:
*
https://github.com/apache/infrastructure-asfyaml/blob/49a86604544bd82e8264de9d8188ed3a5572e05b/asfyaml/feature/github/rulesets.py#L327
*
https://docs.github.com/en/rest/repos/rules?apiVersion=2026-03-10#create-a-repository-ruleset
---
.asf.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.asf.yaml b/.asf.yaml
index 13815dbda0..fb18f16660 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -34,6 +34,8 @@ github:
required_signatures: true
required_linear_history: false
required_conversation_resolution: true
+ required_pull_request_reviews:
+ required_approving_review_count: 1
notifications:
commits: [email protected]
pullrequests: [email protected]
